Bug 2024804: Add custom CA bundle support #40
Conversation
openshift-ci
bot
added
bugzilla/severity-unspecified
|
@bertinatto: This pull request references Bugzilla bug 2024804, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
bertinatto
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
bertinatto
force-pushed
the
custom-ca-bundle
branch
from
afbf9ea
to
f5cf7d8
Compare
|
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
|
@openshift-bot: This pull request references Bugzilla bug 2024804, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 2024804: Add custom CA bundle support I discuss this change with the team and we decided to follow this route. |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test e2e-gcp-csi-migration |
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@bertinatto: This pull request references Bugzilla bug 2024804, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
In OCP, it's possible to set a cluster-wide proxy that operators can use to communicate with external APIs. In addition to that, users can also define a custom CA bundle to be used together with the proxy setting. Currently, we are not using that custom CA bundle and this patch fixes that. The main benefit of injecting the CA bundle using the controllers, as opposed to statically mount it using the manifest file, is that we can watch for changes in the trusted CA bundle store and roll out a new Deployment with the new CA bundle.
bertinatto
force-pushed
the
custom-ca-bundle
branch
from
12cdda3
to
b60bad8
Compare
|
/retest |
|
@bertinatto: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-ci
bot
added
the
qe-approved
|
@bertinatto: All pull requests linked via external trackers have merged: Bugzilla bug 2024804 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.9 |
|
@bertinatto: new pull request created: #41 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In OCP, it's possible to set a cluster-wide proxy that operators can use to communicate with external APIs [1]. In addition to that, users can also define a custom CA bundle to be used together with the proxy setting.
Currently, we are not using that custom CA bundle and this patch fixes that. The main benefit of injecting the CA bundle using the CSI controllers, as opposed to statically mount it using the manifest file, is that we can watch for changes in the trusted CA bundle store and roll out a new Deployment with the new CA bundle injected.
[1] https://docs.openshift.com/container-platform/4.10/networking/enable-cluster-wide-proxy.html
CC @openshift/storage