Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete dependabot so it won't create unnnecesary PRs. #66

Merged
merged 1 commit into from Jun 14, 2021

Conversation

paulfantom
Copy link

I doubt we want to be pinged on PRs like those: https://github.com/openshift/grafana/pulls?q=is%3Apr+is%3Aopen+author%3Aapp%2Fdependabot+sort%3Aupdated-desc or even have them created in the first place.

This PR is not modifying any code that we ship and is only changing CI settings. As such we may proceed without BZ?

/cc @simonpasquier

@openshift-ci openshift-ci bot requested a review from simonpasquier June 7, 2021 10:56
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@simonpasquier
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [paulfantom,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrisonnet
Copy link
Member

Would it make sense to also add it to the gitignore to avoid adding it again in the next upstream sync?

@openshift-merge-robot openshift-merge-robot merged commit 21f5f5d into openshift:master Jun 14, 2021
@paulfantom paulfantom deleted the patch-1 branch June 14, 2021 09:38
@paulfantom
Copy link
Author

It would, if there will be another sync :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants