Merge pull request #594 from rottencandy/fix/pr-filter-26

Add filter to pipelinerun link data
openshift · May 2, 2023 · cdbf9fe · cdbf9fe
2 parents 047cce9 + 3cb9a2e
commit cdbf9fe
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/...cationDetails/tabs/overview/visualization/nodes/__tests__/WorkflowNodeTipContent.spec.tsx b/...cationDetails/tabs/overview/visualization/nodes/__tests__/WorkflowNodeTipContent.spec.tsx
@@ -119,6 +119,11 @@ describe('WorkflowNode', () => {
     const visualization = getController(true);
     const mockGroup = visualization.getNodeById('components');
     const mockElement = mockGroup.getChildren()[0] as Node<NodeModel, WorkflowNodeModelData>;
+    const mockBuildGroup = visualization.getNodeById('builds');
+    const mockBuildElement = mockBuildGroup.getChildren()[1] as Node<
+      NodeModel,
+      WorkflowNodeModelData
+    >;
 
     routerRenderer(<WorkflowNodeTipContent element={mockElement} />);
 
@@ -131,6 +136,10 @@ describe('WorkflowNode', () => {
     expect(linkData.tab).toBe('components');
     expect(linkData.filter.name).toBe('name');
     expect(linkData.filter.value).toBe(mockElement.getLabel());
+    const buildLinkData = getLinkDataForElement(mockBuildElement, 'test-ws');
+    expect(buildLinkData.tab).toBe('activity/pipelineruns');
+    expect(buildLinkData.filter.name).toBe('name');
+    expect(buildLinkData.filter.value).toBe(mockBuildElement.getData().resources[0].metadata.name);
     expect(screen.queryAllByTestId('child-row')).toHaveLength(0);
     expect(screen.queryByText('View logs')).not.toBeInTheDocument();
   });

diff --git a/src/components/ApplicationDetails/tabs/overview/visualization/utils/node-utils.ts b/src/components/ApplicationDetails/tabs/overview/visualization/utils/node-utils.ts
@@ -78,7 +78,7 @@ export const getLinkDataForElement = (
   element: Node<PipelineNodeModel, WorkflowNodeModelData>,
   workspace: string,
 ): { tab?: string; path?: string; filter?: { name: string; value: string } } => {
-  const { workflowType, isDisabled, groupNode, status } = element.getData();
+  const { workflowType, isDisabled, groupNode, status, resources } = element.getData();
   const label = element.getLabel();
 
   switch (workflowType) {
@@ -99,7 +99,10 @@ export const getLinkDataForElement = (
       }
       return {
         tab: 'activity/pipelineruns',
-        // TODO: filter by build once the PLR tab supports filtering
+        filter:
+          !groupNode && !isDisabled && resources?.[0]
+            ? { name: 'name', value: resources[0].metadata.name }
+            : undefined,
       };
     case WorkflowNodeType.TESTS:
     case WorkflowNodeType.APPLICATION_TEST: