feature flag and remove settings page for mvp

[christianvogt]

Fixes

Description

Adds a feature flag for mvp using the flags extension point.

Feature flagged the settings page route as well as the navigation link. Unfortunately there seems to be a bug with the navigation links not obeying feature flags. Therefore these links were simply commented out.

The mvp feature flag can be controlled by the developer using the query string param ?mvp=true|false as well as through the local storage by setting mvp=true|false. By default the flag is enabled.

Type of change

• Feature
• Bugfix
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

The flag can be tested by going directly to the url /hac/stonesoup/workspace-settings with the mvp feature flag set to true or false using the query param or local storage.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@christianvogt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[codecov]

Codecov Report

Merging #296 (ea5c3f1) into main (29c78a1) will decrease coverage by 0.05%.
The diff coverage is 22.22%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   74.15%   74.10%   -0.06%     
==========================================
  Files         430      430              
  Lines        9066     9075       +9     
  Branches     2438     2440       +2     
==========================================
+ Hits         6723     6725       +2     
- Misses       2207     2214       +7     
  Partials      136      136              

Impacted Files	Coverage Δ
src/utils/flag-utils.ts	68.00% <22.22%> (-25.75%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c78a1...ea5c3f1. Read the comment docs.

[karthikjeeyar]

therefore these links were simply commented out.

Okay, once HAC-2703 ticket is resolved, we can uncomment the settings code 👍🏻

/lgtm

[christianvogt]

/retest