Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide release and managed environment nodes in lifecycle visualization for mvp #302

Merged

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented Dec 28, 2022

Fixes

https://issues.redhat.com/browse/HAC-2649

Description

Hides the release and managed environment nodes in the application lifecycle visualization when the MVP flag is set to true.

The mvp feature flag can be controlled by the developer using the query string param ?mvp=true|false as well as through the local storage by setting mvp=true|false.

Note: This PR is built on top of #296, here is the commit to be reviewed is 2ea2edb

Type of change

  • Bugfix

Screen shots / Gifs for design review

MVP flag is set to true:
Screenshot 2022-12-28 at 5 18 56 PM

MVP flag is set to false:
Screenshot 2022-12-28 at 5 19 21 PM

How to test or reproduce?

Visit an Application details page and add &mvp=true to the URL.

Unit tests:

  useAppWorkflowData hook
    ✓ should return workflow nodes without release and managed environments when mvp flag is true (1 ms)

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

cc: @christianvogt @rohitkrai03 @megan-hall

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 28, 2022

@karthikjeeyar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #302 (2ea2edb) into main (29c78a1) will decrease coverage by 0.05%.
The diff coverage is 54.54%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   74.15%   74.10%   -0.06%     
==========================================
  Files         430      430              
  Lines        9066     9086      +20     
  Branches     2438     2448      +10     
==========================================
+ Hits         6723     6733      +10     
- Misses       2207     2216       +9     
- Partials      136      137       +1     
Impacted Files Coverage Δ
src/utils/flag-utils.ts 68.00% <22.22%> (-25.75%) ⬇️
...overview/visualization/hooks/useAppWorkflowData.ts 95.71% <76.92%> (-4.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c78a1...2ea2edb. Read the comment docs.

@christianvogt
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2023
@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2023
@christianvogt christianvogt merged commit 4ba44bd into openshift:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants