Prevent link redirection in disabled action button #527
Conversation
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
+ Coverage 78.55% 78.64% +0.09%
==========================================
Files 433 433
Lines 10156 10162 +6
Branches 2828 2832 +4
==========================================
+ Hits 7978 7992 +14
+ Misses 2063 2059 -4
+ Partials 115 111 -4
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
/retest |
|
@karthikjeeyar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karthikjeeyar, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Fixes
https://issues.redhat.com/browse/HAC-3612
Description
When a user doesn't have a enough permission to perform an action, then the button is disabled but the user is still able to click on the button and it redirects to the underlying link.
This PR also fixes the colour scheme for kebab menu actions.
Type of change
Screen shots / Gifs for design review
Link redirection:
Before:
After:
Kebab menu action color Schemes:
Browser conformance:
/cc @rottencandy