Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch runtime detection fields if runtime selection succeedes #739

Merged

Conversation

rottencandy
Copy link
Contributor

Fixes

https://issues.redhat.com/browse/RHTAPBUGS-479

Description

Formik bug workaround suddenly stopped working, updated to use jaredpalmer/formik#2083 (comment)

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

recording-1690560371.mp4

How to test or reproduce?

(see ticket)

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

@rottencandy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #739 (88f8295) into main (cae73cf) will increase coverage by 0.15%.
Report is 10 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
+ Coverage   83.56%   83.71%   +0.15%     
==========================================
  Files         496      499       +3     
  Lines       12184    12310     +126     
  Branches     3479     3532      +53     
==========================================
+ Hits        10181    10305     +124     
- Misses       1887     1889       +2     
  Partials      116      116              
Files Changed Coverage Δ
...nents/ImportForm/ReviewSection/RuntimeSelector.tsx 97.19% <100.00%> (+0.08%) ⬆️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae73cf...88f8295. Read the comment docs.

@rottencandy
Copy link
Contributor Author

/retest

@rottencandy
Copy link
Contributor Author

/cc @karthikjeeyar

@abhinandan13jan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@rottencandy
Copy link
Contributor Author

/cc @rohitkrai03

@openshift-ci openshift-ci bot requested a review from rohitkrai03 August 2, 2023 15:27
@rohitkrai03
Copy link
Contributor

/retest

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 04c6911 into openshift:main Aug 3, 2023
7 checks passed
@rottencandy rottencandy deleted the fix/runtime-disable-479 branch November 10, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants