Always allow component creation if dockerfile runtime is selected

[rottencandy]

Fixes

https://issues.redhat.com/browse/RHTAPBUGS-469

Description

Always allow component creation if dockerfile runtime is selected.

Type of change

• Feature
• Bugfix
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Screen shots / Gifs for design review

recording-1690205082.mp4

How to test or reproduce?

Use a repo that returns error when detection, and select dockerfile runtime.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[rottencandy]

/retest

[jrichter1]

/test test

[codecov]

Codecov Report

Merging #730 (966c045) into main (a329ef5) will increase coverage by 0.60%.
Report is 48 commits behind head on main.
The diff coverage is 93.75%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
+ Coverage   83.62%   84.23%   +0.60%     
==========================================
  Files         499      499              
  Lines       12295    12954     +659     
  Branches     3521     3836     +315     
==========================================
+ Hits        10282    10912     +630     
- Misses       1896     1924      +28     
- Partials      117      118       +1     

Files Changed	Coverage Δ
...ponents/ImportForm/ReviewSection/ReviewSection.tsx	81.55% <0.00%> (+1.86%)	⬆️
...nents/ImportForm/ReviewSection/RuntimeSelector.tsx	98.19% <100.00%> (+1.00%)	⬆️

... and 27 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a329ef5...966c045. Read the comment docs.

[rottencandy]

/retest

[rohitkrai03]

Even after selecting Dockerfile runtime the create button doesn't get enabled. I have to touch the dockerfile and port fields to enable it.

Screen.Recording.2023-08-03.at.9.09.29.PM.mov

[rottencandy]

Looks like that was the bug which was fixed in #739, I rebased and it's working fine now.

[rottencandy]

/cc @rohitkrai03 @karthikjeeyar

[rohitkrai03]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rottencandy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.