Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cluster install on Alibaba Cloud #1704

Merged
merged 6 commits into from
May 3, 2022
Merged

Add support for cluster install on Alibaba Cloud #1704

merged 6 commits into from
May 3, 2022

Conversation

akhil-rane
Copy link
Contributor

@akhil-rane akhil-rane commented Feb 28, 2022 •
edited

  • Add Alibaba Cloud APIs
  • Implement Alibaba clusterresource builder support
  • Add controller code to provision/deprovision clusters on Alibaba cloud
  • Add hiveutil support for Alibaba cloud

x-ref: https://issues.redhat.com/browse/HIVE-1609
x-ref: https://issues.redhat.com/browse/HIVE-1610
x-ref: https://issues.redhat.com/browse/HIVE-1611

@akhil-rane akhil-rane changed the title Add support for cluster install on Alibaba Cloud WIP: Add support for cluster install on Alibaba Cloud Feb 28, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2022
@akhil-rane
Copy link
Contributor Author

/assign @abutcher

just includes APIs for now. Working on install code

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022 •
edited

Codecov Report

Merging #1704 (018d192) into master (aebcdb3) will decrease coverage by 0.32%.
The diff coverage is 1.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1704      +/-   ##
==========================================
- Coverage   41.95%   41.63%   -0.33%     
==========================================
  Files         346      349       +3     
  Lines       32119    32374     +255     
==========================================
+ Hits        13476    13479       +3     
- Misses      17512    17760     +248     
- Partials     1131     1135       +4
Impacted Files Coverage Δ
contrib/pkg/createcluster/create.go 0.00% <0.00%> (ø)
contrib/pkg/deprovision/alibabacloud.go 0.00% <0.00%> (ø)
contrib/pkg/deprovision/deprovision.go 0.00% <0.00%> (ø)
contrib/pkg/utils/alibabacloud/alibabacloud.go 0.00% <0.00%> (ø)
pkg/clusterresource/alibabacloud.go 0.00% <0.00%> (ø)
pkg/constants/constants.go 100.00% <ø> (ø)
.../clusterdeployment/clusterdeployment_controller.go 61.92% <0.00%> (-0.41%) ⬇️
pkg/install/generate.go 29.53% <0.00%> (-2.43%) ⬇️
pkg/installmanager/installmanager.go 34.01% <0.00%> (-0.50%) ⬇️
...s/hive/v1/machinepool_validating_admission_hook.go 81.34% <0.00%> (-1.99%) ⬇️
... and 4 more

@abutcher
Copy link
Member

abutcher commented Mar 4, 2022

API changes look good to me 👍

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2022
@akhil-rane
Copy link
Contributor Author

/retest

@akhil-rane akhil-rane changed the title WIP: Add support for cluster install on Alibaba Cloud Add support for cluster install on Alibaba Cloud Apr 20, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2022
@akhil-rane
Copy link
Contributor Author

@abutcher This is ready for a review.

abutcher
abutcher reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@abutcher abutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few small things. Is there anything outstanding?

pkg/clusterresource/alibabacloud.go Outdated
type AlibabaCloudBuilder struct {
// AccessKeyID is the Alibaba Cloud access key ID.
AccessKeyID string
// AccessKeySecret is the AWS access key secret.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/AWS/Alibaba Cloud

hack/update-codegen.sh Outdated
@@ -19,7 +19,7 @@ GOFLAGS="" bash ${CODEGEN_PKG}/generate-groups.sh "all" \
GOFLAGS="" bash ${CODEGEN_PKG}/generate-groups.sh "deepcopy" \
github.com/openshift/hive/pkg/client \
github.com/openshift/hive/apis \
"hive:v1/agent hive:v1/aws hive:v1/azure hive:v1/baremetal hive:v1/gcp hive:v1/none hive:v1/openstack hive:v1/ovirt hive:v1/vsphere hive:v1/ibmcloud hivecontracts:v1alpha1" \
"hive:v1/agent hive:v1/alibabacloud hive:v1/aws hive:v1/azure hive:v1/baremetal hive:v1/gcp hive:v1/openstack hive:v1/ovirt hive:v1/vsphere hive:v1/ibmcloud hivecontracts:v1alpha1" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hive:v1/none is removed and should stay, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know how that got removed but I will add it

@akhil-rane akhil-rane mentioned this pull request Apr 28, 2022
Merged
@akhil-rane
Copy link
Contributor Author

@abutcher This is ready for another review

@akhil-rane
Copy link
Contributor Author

/retest

@abutcher
Copy link
Member

abutcher commented May 3, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, akhil-rane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abutcher,akhil-rane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2022

@akhil-rane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 00576bb into openshift:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abutcher abutcher abutcher left review comments

@2uasimojo 2uasimojo Awaiting requested review from 2uasimojo

@suhanime suhanime Awaiting requested review from suhanime

Assignees

@abutcher abutcher

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akhil-rane @abutcher @openshift-merge-robot