-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add machinepool support for Alibaba cloud #1754
Add machinepool support for Alibaba cloud #1754
Conversation
/hold wait for #1704 |
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
==========================================
- Coverage 41.63% 41.55% -0.09%
==========================================
Files 349 352 +3
Lines 32374 32556 +182
==========================================
+ Hits 13479 13528 +49
- Misses 17760 17888 +128
- Partials 1135 1140 +5
|
0eb1f7c
to
72b89e5
Compare
/hold cancel #1704 has merged |
@abutcher this is rebased and good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me /lgtm
/lgtm |
/test e2e |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abutcher, akhil-rane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@akhil-rane: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
x-ref: https://issues.redhat.com/browse/HIVE-1612