Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add machinepool support for Alibaba cloud #1754

Merged

Conversation

akhil-rane
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from dlom and suhanime April 28, 2022 18:38
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2022
@akhil-rane
Copy link
Contributor Author

/hold

wait for #1704

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #1754 (72b89e5) into master (c0296c6) will decrease coverage by 0.08%.
The diff coverage is 26.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
- Coverage   41.63%   41.55%   -0.09%     
==========================================
  Files         349      352       +3     
  Lines       32374    32556     +182     
==========================================
+ Hits        13479    13528      +49     
- Misses      17760    17888     +128     
- Partials     1135     1140       +5     
Impacted Files Coverage Δ
pkg/alibabaclient/client.go 0.00% <0.00%> (ø)
...g/controller/machinepool/machinepool_controller.go 47.98% <0.00%> (-0.96%) ⬇️
pkg/controller/machinepool/alibabacloudactuator.go 61.81% <61.81%> (ø)
pkg/alibabaclient/mock/client_generated.go 62.50% <62.50%> (ø)

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2022
@akhil-rane
Copy link
Contributor Author

/hold cancel

#1704 has merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
@akhil-rane
Copy link
Contributor Author

@abutcher this is rebased and good to go

Copy link
Member

@abutcher abutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me /lgtm

@abutcher
Copy link
Member

abutcher commented May 5, 2022

/lgtm

@abutcher
Copy link
Member

abutcher commented May 5, 2022

/test e2e

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, akhil-rane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abutcher,akhil-rane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

@akhil-rane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d3bedf2 into openshift:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants