Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install log regexes for cert-related network failures #2177

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Dec 8, 2023

These were showing up as FallbackInsvalidInstallConfig with a generic message. Make them more specific/scrutable/actionable.

HIVE-2360

These were showing up as `FallbackInsvalidInstallConfig` with a generic
message. Make them more specific/scrutable/actionable.

HIVE-2360
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2023
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5f809f) 57.75% compared to head (49c009b) 57.75%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2177   +/-   ##
=======================================
  Coverage   57.75%   57.75%           
=======================================
  Files         187      187           
  Lines       25984    25984           
=======================================
  Hits        15006    15006           
  Misses       9723     9723           
  Partials     1255     1255           

@2uasimojo
Copy link
Member Author

/assign @lleshchi

/hold pending ack from Atif (see card)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
@lleshchi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, lleshchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2uasimojo
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit ad99b9e into openshift:master Dec 20, 2023
9 checks passed
@2uasimojo 2uasimojo deleted the HIVE-2360/openstack-cert-fail-regexes branch December 20, 2023 21:53
@2uasimojo
Copy link
Member Author

/cherry-pick mce-2.4

@openshift-cherrypick-robot

@2uasimojo: #2177 failed to apply on top of branch "mce-2.4":

Applying: Add install log regexes for cert-related network failures
Using index info to reconstruct a base tree...
M	config/configmaps/install-log-regexes-configmap.yaml
M	pkg/controller/clusterprovision/installlogmonitor_test.go
M	pkg/operator/assets/bindata.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/assets/bindata.go
Auto-merging pkg/controller/clusterprovision/installlogmonitor_test.go
CONFLICT (content): Merge conflict in pkg/controller/clusterprovision/installlogmonitor_test.go
Auto-merging config/configmaps/install-log-regexes-configmap.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add install log regexes for cert-related network failures
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick mce-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@2uasimojo
Copy link
Member Author

Manual cherry-pick to mce-2.4 at #2187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants