-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install log regexes for cert-related network failures #2177
Add install log regexes for cert-related network failures #2177
Conversation
These were showing up as `FallbackInsvalidInstallConfig` with a generic message. Make them more specific/scrutable/actionable. HIVE-2360
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2177 +/- ##
=======================================
Coverage 57.75% 57.75%
=======================================
Files 187 187
Lines 25984 25984
=======================================
Hits 15006 15006
Misses 9723 9723
Partials 1255 1255 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, lleshchi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/cherry-pick mce-2.4 |
@2uasimojo: #2177 failed to apply on top of branch "mce-2.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual cherry-pick to mce-2.4 at #2187 |
These were showing up as
FallbackInsvalidInstallConfig
with a generic message. Make them more specific/scrutable/actionable.HIVE-2360