Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install log regexes for cert-related network failures #2187

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Jan 16, 2024

These were showing up as FallbackInsvalidInstallConfig with a generic message. Make them more specific/scrutable/actionable.

HIVE-2360

(cherry picked from commit 49c009b)

These were showing up as `FallbackInsvalidInstallConfig` with a generic
message. Make them more specific/scrutable/actionable.

HIVE-2360

(cherry picked from commit 49c009b)
@openshift-ci openshift-ci bot requested review from dlom and suhanime January 16, 2024 21:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@2uasimojo
Copy link
Member Author

/assign @lleshchi

Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33d6ae9) 57.50% compared to head (86d3d3e) 57.50%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           mce-2.4    #2187   +/-   ##
========================================
  Coverage    57.50%   57.50%           
========================================
  Files          187      187           
  Lines        25739    25739           
========================================
  Hits         14802    14802           
  Misses        9700     9700           
  Partials      1237     1237           

@lleshchi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, lleshchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eb033fe into openshift:mce-2.4 Jan 17, 2024
8 checks passed
@2uasimojo 2uasimojo deleted the HIVE-2360/cert-net-regexes-2.4 branch January 18, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants