-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Bump to install-config v0.12.0 #222
*: Bump to install-config v0.12.0 #222
Conversation
1a7e48d
to
5207667
Compare
All green except for e2e-aws (and is that actually wired up to anything in this repo?). Ping @dgoodwin |
/lgtm |
I would prefer to see the cluster-network-operator change to |
/retest |
Ah, good reference. Can you file an issue in their repo? |
I suspect buggy cluster-name detection feeding into here (although I'm still not clear on how Hive is getting looped in to e2e-aws). |
Cluster-name detection is from here. cluster.cluster.k8s.io may not be the canonical location to look that up (not sure if that was affected by the recent cluster->machine API rename or not). |
With openshift/installer#1169, "cluster name" is much less of a thing than it used to be (now the focus is on the full cluster domain). And I'm not really clear on the e2e test setup; which cluster was the old |
e2e:
which is openshift/release#2905. /retest |
/lgtm |
/test e2e |
UUIDGen is making things too long: nal: "name" cannot be longer than 32 characters: "3948e3b5-0dcc-4f7d-8390-4795aa8d99f2-ext"" |
This highlights a bug that needs to be addressed in the installer as well. I will file an issue there. |
4556ee5
to
3f1539d
Compare
e2e:
/retest |
Looks like several names still too long. |
946ce2c
to
742d472
Compare
Catching up with openshift/installer@dafc79f0 (Generate Network.cluster config instead of NetworkConfig.networkoperator, 2019-01-15, openshift/installer#1013), openshift/installer@3b393da8 (pkg/types/aws/machinepool: Drop IAM-role overrides, 2019-01-30, openshift/installer#1154), and openshift/installer@9ad20c35 (pkg/destroy/aws: Remove ClusterName consumer, 2019-01-31, openshift/installer#1170). The uint32 -> int32 cast is slightly dangerous, because it will silently wrap overflowing values [1,2]. But I'll try and get the installer updated to use unsigned types as well, and then we won't have to worry about converting. [1]: golang/go#19624 [2]: golang/go#30209
Generated by manually updating Gopkg.toml and then running: $ dep ensure with: $ dep version dep: version : v0.5.0-31-g73b3afe build date : 2019-02-08 git hash : 73b3afe go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false
The old cluster-name extraction was leading to errors like [1]: error: error executing jsonpath "{ .items[].metadata.name }": array index out of bounds: index 0, length 0 Creating ClusterDeployment Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template: template was: { .items[].metadata.name } object given to jsonpath engine was: map[string]interface {}{"kind":"List", "apiVersion":"v1", "metadata":map[string]interface {}{"selfLink":"", "resourceVersion":""}, "items":[]interface {}{}}-1 Error from server (Invalid): Secret "Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template:\n\ttemplate was:\n\t\t{ .items[].metadata.name }\n\tobject given to jsonpath engine was:\n\t\tmap[string]interface {}{\"kind\":\"List\", \"apiVersion\":\"v1\", \"metadata\":map[string]interface {}{\"selfLink\":\"\", \"resourceVersion\":\"\"}, \"items\":[]interface {}{}}-1-aws-creds" is invalid: [metadata.name: Invalid value: "Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template:\n\ttemplate was:\n\t\t{ .items[].metadata.name }\n\tobject given to jsonpath engine was:\n\t\tmap[string]interface {}{\"kind\":\"List\", \"apiVersion\":\"v1\", \"metadata\":map[string]interface {}{\"selfLink\":\"\", \"resourceVersion\":\"\"}, \"items\":[]interface {}{}}-1-aws-creds": must be no more than 253 characters, metadata.name: Invalid value: "Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template:\n\ttemplate was:\n\t\t{ .items[].metadata.name }\n\tobject given to jsonpath engine was:\n\t\tmap[string]interface {}{\"kind\":\"List\", \"apiVersion\":\"v1\", \"metadata\":map[string]interface {}{\"selfLink\":\"\", \"resourceVersion\":\"\"}, \"items\":[]interface {}{}}-1-aws-creds": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')] We don't actually need to match anything for our cluster names, so just use a locally-generated UUID. The cut avoids [2]: level=error msg="Error: module.vpc.aws_lb.api_internal: \"name\" cannot be longer than 32 characters: \"3948e3b5-0dcc-4f7d-8390-4795aa8d99f2-int\"" although there is installer work in progress to protect from "user supplies long cluster name". [1]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_hive/222/pull-ci-openshift-hive-master-e2e/80/build-log.txt [2]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_hive/222/pull-ci-openshift-hive-master-e2e/102/build-log.txt
This script has been 100644 since it landed in 8bcee7e (Add e2e test that installs hive and creates a cluster, 2019-01-25, openshift#191). I'm not sure why that wasn't a problem before, but I just saw [1]: hack/e2e-test.sh make: execvp: hack/e2e-test.sh: Permission denied make: *** [test-e2e] Error 127 [1]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_hive/222/pull-ci-openshift-hive-master-e2e/106/build-log.txt
742d472
to
fe8c892
Compare
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/override e2e |
@dgoodwin: dgoodwin unauthorized: /override is restricted to repo administrators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override e2e |
1 similar comment
/override e2e |
/override ci/prow/e2e |
@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'd kept this in 3b393da (pkg/types/aws/machinepool: Drop IAM-role overrides, 2019-01-30, openshift#1154) to support CI. But with openshift/release@d31f601e (ci-operator/templates/openshift: Bump install-config.yaml to v1beta2, 2019-02-02, openshift/release#2772) and openshift/hive@ab7ee975 (*: Bump to install-config v0.12.0, 2019-02-14, openshift/hive#222) landed, we no longer need the workaround.
The uuidgen approach is from fce3741 (hack/e2e-test: Use uuidgen to create the cluster name, 2019-02-19, openshift#222), where we were working around a broken oc call and the installer's poor handling of long cluster names. The long-name handling has since been fixed, so this commit drops the workaround 'cut'. It also adds a 'hive-' prefix to make it easier to track down issues when we leak CI resources.
Catching up with openshift/installer@dafc79f0 (openshift/installer#1013) and openshift/installer@3b393da8 (openshift/installer#1154).
The uint32 -> int32 cast is slightly dangerous, because it will silently wrap overflowing values (golang/go#19624, golang/go#30209). But I'll try and get the installer updated to use unsigned types as well, and then we won't have to worry about converting.