imageset: do not use oc adm to get installer and cli images #896
Conversation
openshift-ci-robot
added
the
approved
Add github.com/openshift/api/image in order to parse payload images from the release image.
staebler
force-pushed
the
discover_images
branch
from
9c19002
to
a0fe9d1
Compare
staebler
force-pushed
the
discover_images
branch
3 times, most recently
from
67b2c30
to
7c888ad
Compare
| return errors.Wrap(err, "unable to load release image-references") | ||
| } | ||
| if is.Kind != "ImageStream" || is.APIVersion != "image.openshift.io/v1" { | ||
| return errors.Wrap(err, "unrecognized image-references in release payload") |
There was a problem hiding this comment.
Can you confirm this works as far back as 4.1? We could have the discussion if not but it's a lot easier if we can just keep supporting 4.1.
There was a problem hiding this comment.
Yep. I will check on that.
There was a problem hiding this comment.
This worked with https://registry.svc.ci.openshift.org/v2/ocp/release/manifests/4.1.0-0.nightly-2020-03-21-052817. Testing did reveal a problem where the pull secret was not being used. I updated the code to add the pull secret to the pod spec.
Instead of using oc adm, load the release image in a container and parse the installer and cli images from the image-references file.
staebler
force-pushed
the
discover_images
branch
from
7c888ad
to
b8afd7a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cherry-pick #896 to OCM 4.4.0
Instead of using oc adm, load the release image in a container and parse the installer and cli images from the image-references file.