Implement Hive uninstallation via deleting HiveConfig 'hive'. #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the HiveConfig named 'hive' (the only name we recognize) is deleted, Hive components will be torn down. This is accomplished by automatically adding owner references to most resources the hive-operator creates, to the HiveConfig hive. Once deleted we let kubernetes garbage collection take care of cleaning everything up.
|
This is a cherry-pick of #952 for OCM, mostly just to make sure e2e tests pass after backport. |
openshift-ci-robot
added
the
approved
|
/test e2e |
|
Added a fix for the OpenShift specific error. |
dgoodwin
force-pushed
the
cp-uninstall-hive-ocm
branch
from
61e17c5
to
19b0a51
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the HiveConfig named 'hive' (the only name we recognize) is deleted,
Hive components will be torn down.
This is accomplished by automatically adding owner references to most
resources the hive-operator creates, to the HiveConfig hive. Once
deleted we let kubernetes garbage collection take care of cleaning
everything up.