Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: CIDR allow list for API server access #1419

Closed
wants to merge 1 commit into from

Conversation

sjenning
Copy link
Contributor

What this PR does / why we need it:
Implements CIDR allow list for API server access
https://issues.redhat.com/browse/HOSTEDCP-240

WIP: Still need to figure out the private address range the nodes use to connect over PrivateLink so we can always allow that.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2022
@netlify
Copy link

netlify bot commented May 26, 2022

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit b6cae24
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/628fd8d0f6562c000878b884
😎 Deploy Preview https://deploy-preview-1419--hypershift-docs.netlify.app/reference/api
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@csrwng
Copy link
Contributor

csrwng commented May 26, 2022

This lgtm, I assume it's WIP because you're still testing it?

@sjenning
Copy link
Contributor Author

WIP because I need to add a rule that is always present for private clusters to allow nodes access over PrivateLink

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@sjenning: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity b6cae24 link false /test capi-provider-agent-sanity
ci/prow/e2e-kubevirt-gcp-ovn b6cae24 link false /test e2e-kubevirt-gcp-ovn
ci/prow/e2e-aws b6cae24 link true /test e2e-aws
ci/prow/e2e-aws-nested b6cae24 link false /test e2e-aws-nested

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alvaroaleman
Copy link
Contributor

@sjenning
Copy link
Contributor Author

This is a dead end. NetworkPolicies are not a suitable mechanism for this with the SNATing that occurs for off cluster traffic.

@sjenning sjenning closed this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants