Drop kas call in agent ReconcileCAPIInfraCR and fail if no ign

[enxebre]

What this PR does / why we need it:
This add unit tests and fixes the ReconcileCAPIInfraCR agent implementation to avoid an unncesesary kas call to fetch the HCP, since all needed info is available already.

Aditionally it returns early if there's no ign endpoint to ensure we create the agentCluster only after ignition endpoint exists so AgentClusterInstall is only created with the right ign to boot machines.
https://bugzilla.redhat.com/show_bug.cgi?id=2097895
https://github.com/openshift/assisted-service/blob/241ad46db74add5f16e153f5f7ba0a5496fb06ba/pkg/validating-webhooks/hiveextension/v1beta1/agentclusterinstall_admission_hook.go#L185
https://github.com/openshift/cluster-api-provider-agent/blob/master/controllers/agentcluster_controller.go#L126
This change honours the following statement:
For AgentClusterInstall/ClusterDeployment if the input is empty, the value is defaulted so the field is optional and immutable. For CAPI is effectively required and immutable.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	cbfb6f2
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/62ac3850e3634f000930c881
😎 Deploy Preview	https://deploy-preview-1469--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[enxebre]

If we don't want to return early when there's no ignition I'll update the PR so still add unit tests and save the unnecessary kas call cc @eranco74 @avishayt

[avishayt]

/lgtm

[openshift-ci]

New changes are detected. LGTM label has been removed.

[enxebre]

/hold
for @csrwng and @sjenning to cancel

[csrwng]

/hold cancel
/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD 069d7d1 and 8 for PR HEAD 9a0308a in total

[openshift-ci]

@enxebre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/capi-provider-agent-sanity	9a0308a	link	false	/test capi-provider-agent-sanity

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.