New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oauth server: Route external traffic through guest cluster #1522
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change makes the oauth server route external traffic through the guest cluster, in order to enable communication with IDPs that are only accessible from the guest cluster network. https://issues.redhat.com/browse/HOSTEDCP-421
can we please add it to the list explaining why here https://github.com/openshift/enhancements/blob/master/enhancements/hypershift/networking/networking.md#konnectivity-socks5-proxy |
/lgtm |
/hold |
/hold cancel |
@alvaroaleman: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There's exceptions to this rule needed in hypershift (the login functionaility for 4.11 is currently broken). @hasueki is going to add a pr short term for no proxy for iam.cloud.ibm.com,iam.test.cloud.ibm.com It will be important to have for our next Satellite 4.11 release. |
SGTM, but lets gate this to IBM cloud clusters |
This change makes the oauth server route external traffic through the
guest cluster, in order to enable communication with IDPs that are only
accessible from the guest cluster network.
https://issues.redhat.com/browse/HOSTEDCP-421
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist