Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth server: Route external traffic through guest cluster #1522

Merged
merged 1 commit into from Jul 8, 2022

Conversation

alvaroaleman
Copy link
Contributor

This change makes the oauth server route external traffic through the
guest cluster, in order to enable communication with IDPs that are only
accessible from the guest cluster network.

https://issues.redhat.com/browse/HOSTEDCP-421

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from csrwng and sjenning July 6, 2022 18:11
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022
This change makes the oauth server route external traffic through the
guest cluster, in order to enable communication with IDPs that are only
accessible from the guest cluster network.

https://issues.redhat.com/browse/HOSTEDCP-421
@enxebre
Copy link
Member

enxebre commented Jul 7, 2022

@enxebre
Copy link
Member

enxebre commented Jul 7, 2022

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 82d3c60 and 8 for PR HEAD 8372ffd in total

@alvaroaleman
Copy link
Contributor Author

/hold
#1526 needs to merge first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2022
@alvaroaleman
Copy link
Contributor Author

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@alvaroaleman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity 8372ffd link false /test capi-provider-agent-sanity
ci/prow/e2e-aws-nested 8372ffd link false /test e2e-aws-nested

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 06ae3cf into openshift:main Jul 8, 2022
@relyt0925
Copy link
Contributor

relyt0925 commented Sep 2, 2022

There's exceptions to this rule needed in hypershift (the login functionaility for 4.11 is currently broken). @hasueki is going to add a pr short term for no proxy for iam.cloud.ibm.com,iam.test.cloud.ibm.com

It will be important to have for our next Satellite 4.11 release.

@alvaroaleman
Copy link
Contributor Author

a pr short term for no proxy for iam.cloud.ibm.com,iam.test.cloud.ibm.com

SGTM, but lets gate this to IBM cloud clusters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants