Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional RestoreSnapshotURL should have omitempty #1585

Merged
merged 1 commit into from Jul 19, 2022
Merged

Optional RestoreSnapshotURL should have omitempty #1585

merged 1 commit into from Jul 19, 2022

Conversation

rokej
Copy link
Contributor

@rokej rokej commented Jul 19, 2022

What this PR does / why we need it:
The optional field RestoreSnapshotURL does not have json omitempty. When the HypershiftDeployment controller tries to update a HostedCluster CR, the following error occurs because of missing omitempty.

spec.hostedClusterSpec.etcd.managed.storage.restoreSnapshotURL: Invalid value: "null": spec.hostedClusterSpec.etcd.managed.storage.restoreSnapshotURL in body must be of type array: "null"

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Signed-off-by: Roke Jung <roke@redhat.com>
@rokej rokej changed the base branch from main to release-4.11 July 19, 2022 02:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

@rokej: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Optional RestoreSnapshotURL should have omitempty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Jul 19, 2022

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit b23ee04
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/62d618b9a88a510009ce49c4
😎 Deploy Preview https://deploy-preview-1585--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 352e547 and 8 for PR HEAD b23ee04 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

@rokej: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kubevirt-gcp-ovn b23ee04 link false /test e2e-kubevirt-gcp-ovn
ci/prow/e2e-aws b23ee04 link true /test e2e-aws
ci/prow/capi-provider-agent-sanity b23ee04 link false /test capi-provider-agent-sanity
ci/prow/e2e-kubevirt-azure-ovn b23ee04 link false /test e2e-kubevirt-azure-ovn
ci/prow/e2e-aws-metrics b23ee04 link false /test e2e-aws-metrics
ci/prow/e2e-aws-all b23ee04 link false /test e2e-aws-all

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 685115c into openshift:release-4.11 Jul 19, 2022
@hardys
Copy link
Contributor

hardys commented Jul 19, 2022

/lgtm

Thanks for the fix - sorry I missed that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants