Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow certain EndpointAccess transitions #1761

Merged

Conversation

sjenning
Copy link
Contributor

What this PR does / why we need it:
First step for https://issues.redhat.com/browse/HOSTEDCP-572

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@csrwng
Copy link
Contributor

csrwng commented Sep 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@sjenning sjenning force-pushed the allow-endpointaccess-transition branch from 7d130cf to 8815371 Compare September 28, 2022 21:32
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@sjenning
Copy link
Contributor Author

Since it failed e2e due to #1764 I went ahead and included the code to make this work end to end

@sjenning sjenning changed the title hypershift-operator: webhook: allow certain EndpointAccess transitions Allow certain EndpointAccess transitions Sep 28, 2022
@sjenning
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

@sjenning: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity 8815371 link false /test capi-provider-agent-sanity
ci/prow/kubevirt-e2e-kubevirt-gcp-ovn 8815371 link false /test kubevirt-e2e-kubevirt-gcp-ovn
ci/prow/kubevirt-e2e-kubevirt-azure-ovn 8815371 link false /test kubevirt-e2e-kubevirt-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Oct 12, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f1b8426 and 2 for PR HEAD 8815371 in total

@openshift-merge-robot openshift-merge-robot merged commit f21afb7 into openshift:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants