Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTH-323: pki: split out konnectivity certs from the rootCA #1891

Merged
merged 4 commits into from
Feb 8, 2023
Merged

AUTH-323: pki: split out konnectivity certs from the rootCA #1891

merged 4 commits into from
Feb 8, 2023

Conversation

stlaz
Copy link
Contributor

@stlaz stlaz commented Nov 22, 2022

/assign @csrwng
/cc @ibihim

@openshift-ci openshift-ci bot requested a review from ibihim November 22, 2022 10:24
@netlify
Copy link

netlify bot commented Nov 22, 2022 •
edited
Loading

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit ccd8e2b
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/63d93f623dab2e0008f338e0
😎 Deploy Preview https://deploy-preview-1891--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stlaz stlaz force-pushed the konnectivity_pki branch 2 times, most recently from 5c7f254 to 4c2339d Compare November 22, 2022 14:22
@stlaz
Copy link
Contributor Author

stlaz commented Nov 23, 2022 •
edited
Loading

/retest-required

edit: I removed the previous retest-required comment so as not to pollute the comments but the result of the previous run seemed to have been tainted by a failed cluster install

@stlaz
Copy link
Contributor Author

stlaz commented Nov 24, 2022

/test e2e-aws

@stlaz
Copy link
Contributor Author

stlaz commented Nov 25, 2022 •
edited
Loading

/test e2e-aws
infra seems to have failed

@stlaz
Copy link
Contributor Author

stlaz commented Nov 25, 2022

adding root CA in order to make the upgrade test pass

@stlaz stlaz changed the title AUTH 323: pki: split out konnectivity certs from the rootCA AUTH-323: pki: split out konnectivity certs from the rootCA Nov 28, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022
@stlaz
Copy link
Contributor Author

stlaz commented Dec 1, 2022

rebased on current master

@stlaz
Copy link
Contributor Author

stlaz commented Dec 1, 2022 •
edited
Loading

/test e2e-aws
Odlly enough, the tests are now all failing, while they were green before. Let's see if that's a one-off.

edit: looks like it was an infra issue

@csrwng
Copy link
Contributor

csrwng commented Dec 2, 2022

/retest-required

@csrwng
Copy link
Contributor

csrwng commented Dec 2, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7868340 and 2 for PR HEAD 11974f5 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 04c6fed and 1 for PR HEAD 11974f5 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 07d4431 and 0 for PR HEAD 11974f5 in total

@openshift-ci-robot
Copy link

/hold

Revision 11974f5 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
@stlaz
Copy link
Contributor Author

stlaz commented Dec 6, 2022

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD afcbd08 and 2 for PR HEAD 11974f5 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7563598 and 1 for PR HEAD 11974f5 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a4fbc63 and 0 for PR HEAD 11974f5 in total

@stlaz
Copy link
Contributor Author

stlaz commented Feb 1, 2023

/test e2e-aws

@stlaz
Copy link
Contributor Author

stlaz commented Feb 3, 2023

/test e2e-aws
just to see if it's really broken so that I have something to work with next week

@stlaz
Copy link
Contributor Author

stlaz commented Feb 6, 2023

/hold cancel
tests passed \o/

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2023
csrwng
csrwng reviewed Feb 6, 2023
View reviewed changes
...l-plane-operator/hostedclusterconfigoperator/controllers/resources/konnectivity/reconcile.go Outdated
func ReconcileKonnectivityAgentSecret(secret, source *corev1.Secret) {
secret.Data = map[string][]byte{}
for k, v := range source.Data {
secret.Data[k] = v
}
}

func CopyConfigMap(cm, source *corev1.ConfigMap) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, this belongs in https://github.com/openshift/hypershift/tree/main/support/util

@csrwng
Copy link
Contributor

csrwng commented Feb 6, 2023

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 37e8a31 and 2 for PR HEAD f522220 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3892f0d and 1 for PR HEAD f522220 in total

@stlaz
Copy link
Contributor Author

stlaz commented Feb 7, 2023

/retest-required

1 similar comment
@stlaz
Copy link
Contributor Author

stlaz commented Feb 7, 2023

/retest-required

@stlaz
Copy link
Contributor Author

stlaz commented Feb 7, 2023

/retest-required

<testsuite tests="208" failures="0" time="0.013000" name="hypershift-e2e" timestamp="2023-02-07T14:48:56Z">
suggests that the tests actually passed? It seems that the wrapper failed? It's unclear from the logs in the CI.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 765627d and 0 for PR HEAD f522220 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023 •
edited
Loading

@stlaz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity 11974f5 link false /test capi-provider-agent-sanity
ci/prow/kubevirt-e2e-kubevirt-azure-ovn 11974f5 link false /test kubevirt-e2e-kubevirt-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/hold

Revision f522220 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2023
@csrwng
Copy link
Contributor

csrwng commented Feb 8, 2023

/retest-required

@stlaz
Copy link
Contributor Author

stlaz commented Feb 8, 2023

/hold cancel
the tests are green again \o/

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit e949ff2 into openshift:main Feb 8, 2023
@stlaz stlaz mentioned this pull request Feb 8, 2023
Merged
@csrwng
Copy link
Contributor

csrwng commented Feb 10, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 10, 2023
Merged
@openshift-cherrypick-robot
Copy link

@csrwng: new pull request created: #2156

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyrtapz kyrtapz mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng csrwng left review comments

@ibihim ibihim Awaiting requested review from ibihim

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stlaz @csrwng @openshift-ci-robot @wallylewis @openshift-cherrypick-robot @openshift-merge-robot