Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kube API server panic: Fix podsecurity annotations on kube-system #2057

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jan 19, 2023

What this PR does / why we need it:
This commit adds pod security annotations to the kube-system namespace before reconciling the konnectivity agent daemonset. This prevents a warning that causes the kube-apiserver to crash.

Checklist

  • Subject and description added to both, commit and PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
This commit adds pod security annotations to the kube-system namespace
before reconciling the konnectivity agent daemonset. This prevents a
warning that causes the kube-apiserver to crash.
@sjenning
Copy link
Contributor

/lgtm
If it passes e2e, we know we avoided it 🤞

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 75e294a into openshift:main Jan 19, 2023
@csrwng csrwng deleted the fix_panic branch July 14, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants