Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-833: Add Golang check for 'go list' errors in Makefile #2193

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Add Golang check for 'go list' errors in Makefile within deps section.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-833

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Add Golang check for 'go list' errors in Makefile within deps section.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@celebdor
Copy link
Contributor

celebdor commented Feb 17, 2023

/retitle HOSTEDCP-833: Add Golang check for 'go list' errors in Makefile

@openshift-ci openshift-ci bot changed the title HOSTEDCP-833 - Add Golang check for 'go list' errors in Makefile HOSTEDCP-833: Add Golang check for 'go list' errors in Makefile Feb 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2023

@bryan-cox: This pull request references HOSTEDCP-833 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Add Golang check for 'go list' errors in Makefile within deps section.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-833

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor

/approve
/lgtm

retest verify after #2194 merges

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e7653a0 and 2 for PR HEAD 142eec4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7a2d284 and 1 for PR HEAD 142eec4 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2023

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 25fc6fe into openshift:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants