Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-969: Move guest cluster resource deletion metric #2463

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Apr 21, 2023

What this PR does / why we need it:
/hold
Needs #2459

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-area labels Apr 21, 2023
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Apr 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Apr 21, 2023
@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 2840732
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/64479922670c33000821f67c
😎 Deploy Preview https://deploy-preview-2463--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@enxebre enxebre changed the title Move guest cluster resource deletion metric HOSTEDCP-969: Move guest cluster resource deletion metric Apr 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 21, 2023

@enxebre: This pull request references HOSTEDCP-969 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
/hold
Needs #2459

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre enxebre force-pushed the move-guest-cluster-resource-deletion-metric branch from a73c5c5 to 2840732 Compare April 25, 2023 09:10
@enxebre
Copy link
Member Author

enxebre commented Apr 25, 2023

/hold cancel

@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 25, 2023
@enxebre enxebre force-pushed the move-guest-cluster-resource-deletion-metric branch from 2840732 to 047618d Compare April 25, 2023 10:45
@muraee
Copy link
Contributor

muraee commented Apr 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8e5d967 and 2 for PR HEAD 047618d in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 83c3657 into openshift:main Apr 25, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants