Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.13: Add management cluster KAS network policy #2786

Merged
merged 3 commits into from Jul 20, 2023
Merged

4.13: Add management cluster KAS network policy #2786

merged 3 commits into from Jul 20, 2023

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Jul 10, 2023 •
edited

What this PR does / why we need it:
Cherry-picks #2796
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@enxebre
Copy link
Member Author

enxebre commented Jul 10, 2023

/hold

@openshift-ci openshift-ci bot added do-not-merge/needs-area do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 10, 2023
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Jul 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jul 10, 2023
@enxebre enxebre force-pushed the kas-policy-4.13 branch 3 times, most recently from 409f98f to da1f769 Compare July 11, 2023 08:02
@enxebre
Add management cluster kas network policy
f09a43d 
As part of hardening CP workloads, this introduces a network policy that:

Selects pods excluding the ones having NeedManagementKASAccessLabel and specific operands.

It denies egress traffic to the management cluster clusterNetwork and to the KAS endpoints.
@enxebre
Copy link
Member Author

enxebre commented Jul 11, 2023

/test e2e-aws

@sjenning
Copy link
Contributor

/hold
until we figure out why 4.14 periodic is breaking on this

@enxebre
Copy link
Member Author

enxebre commented Jul 11, 2023

needs #2796

@enxebre
Copy link
Member Author

enxebre commented Jul 12, 2023

/test e2e-aws

1 similar comment
@enxebre
Copy link
Member Author

enxebre commented Jul 12, 2023

/test e2e-aws

@muraee
Copy link
Contributor

muraee commented Jul 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@enxebre
Make CAPI pod selector backward compatible
ca6f1e4 
This is a follow up for openshift#2796
With out this existing HCs upgrading to this version of the HO fail to reconcile CAPI as they attempt to change the labelSelector.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@enxebre
Copy link
Member Author

enxebre commented Jul 18, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@muraee
Copy link
Contributor

muraee commented Jul 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@enxebre enxebre mentioned this pull request Jul 18, 2023
Merged
4 tasks
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 855d1ac and 2 for PR HEAD ca6f1e4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6ce9532 and 1 for PR HEAD ca6f1e4 in total

@enxebre
Copy link
Member Author

enxebre commented Jul 19, 2023

/test e2e-aws

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f268020 and 0 for PR HEAD ca6f1e4 in total

@openshift-ci-robot
Copy link

/hold

Revision ca6f1e4 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2023
@enxebre
Copy link
Member Author

enxebre commented Jul 20, 2023

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Jul 20, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 962bd11 into openshift:release-4.13 Jul 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel Awaiting requested review from davidvossel

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enxebre @sjenning @muraee @openshift-ci-robot @openshift-merge-robot