Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kas policy 4.12 #2826

Merged
merged 6 commits into from Jul 24, 2023
Merged

Kas policy 4.12 #2826

merged 6 commits into from Jul 24, 2023

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Jul 18, 2023

What this PR does / why we need it:

cherry-picks
#2786
And to keep the conflicts reasonably clean
#2181
#2439
It also includes pod_exec originally introduced in this PR as part of a conflict resolution

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

qinqon and others added 5 commits July 18, 2023 10:56
@qinqon @enxebre
kubevirt: Block metadata server egress
e815b02 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@sjenning @enxebre
add KAS egress network policy
21eae84
@enxebre
Move network policies into their own file
799b85b
@enxebre
Add management cluster kas network policy
42b83b1 
As part of hardening CP workloads, this introduces a network policy that:

Selects pods excluding the ones having NeedManagementKASAccessLabel and specific operands.

It denies egress traffic to the management cluster clusterNetwork and to the KAS endpoints.
@enxebre
Make CAPI pod selector backward compatible
2e489d5 
This is a follow up for openshift#2796
With out this existing HCs upgrading to this version of the HO fail to reconcile CAPI as they attempt to change the labelSelector.
@enxebre
Copy link
Member Author

enxebre commented Jul 18, 2023

/hold

@openshift-ci openshift-ci bot added do-not-merge/needs-area do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 18, 2023
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release labels Jul 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jul 18, 2023
@enxebre
Copy link
Member Author

enxebre commented Jul 18, 2023

/test e2e-aws

2 similar comments
@enxebre
Copy link
Member Author

enxebre commented Jul 19, 2023

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Jul 20, 2023

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Jul 24, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@muraee
Copy link
Contributor

muraee commented Jul 24, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023 •
edited

@enxebre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ho-4.13-e2e-aws ea17410 link false /test ho-4.13-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 69ab21c and 2 for PR HEAD ea17410 in total

@openshift-merge-robot openshift-merge-robot merged commit 255e1b6 into openshift:release-4.12 Jul 24, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel Awaiting requested review from davidvossel

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@enxebre @muraee @openshift-ci-robot @openshift-merge-robot @qinqon @sjenning