HOSTEDCP-1232: Add clusterName label to CAPI kubeconfig secret

[muraee]

What this PR does / why we need it:

Starting from v1.5, CAPI uses a cached client to retrieve the kubeconfig secret. However, only secrets with the clusterName label cluster.x-k8s.io/cluster-name are cached, see:
https://github.com/kubernetes-sigs/cluster-api/pull/8940/files#diff-8bdee7925f4d1adc50383754391472636156a2a857a7c76290f6073c8d83f5cdR216

This PR ensures we can consume CAPI v1.5+, by adding the required label to the kubeconfig secret generated for CAPI.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1232

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@muraee: This pull request references HOSTEDCP-1232 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

Starting from v1.5, CAPI uses a cached client to retrieve the kubeconfig secret. However, only secrets with the clusterName label cluster.x-k8s.io/cluster-name are cached, see:
https://github.com/kubernetes-sigs/cluster-api/pull/8940/files#diff-8bdee7925f4d1adc50383754391472636156a2a857a7c76290f6073c8d83f5cdR216

This PR ensures we can consume CAPI v1.5+, by adding the required label to the kubeconfig secret generated for CAPI.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1232

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damdo]

/lgtm
Thanks

[muraee]

/test e2e-aws

[enxebre]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@muraee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.