Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17286,OCPCLOUD-2222: Merge https://github.com/kubernetes-sigs/cluster-api:v1.5.2 (3290c5a) into master #181

Merged
merged 833 commits into from Oct 16, 2023

Conversation

damdo
Copy link
Member

@damdo damdo commented Oct 5, 2023

No description provided.

k8s-ci-robot and others added 30 commits June 23, 2023 07:29
…etcd-management-in-capim

🌱 Improve etcd management in CAPIM
…one-workloadCluster-for-reconcile

🌱 Kcp use one workload cluster for reconcile
…provement-etcd-client

🌱 Change endpoints to endpoint in the etcd client
…rl-uncached

🌱 controller/machine: use unstructured caching client
Signed-off-by: Stefan Büringer buringerst@vmware.com
…pper-1-25

🐛 test/capd: fix kind mapper entry for v1.25.11
Signed-off-by: Stefan Büringer buringerst@vmware.com
…edundant-get-machines

🌱 KCP: drop redundant get machines
…cally-set-kubelet-args-for-CAPD

🌱 Automatically set kubelet args for capd
Signed-off-by: Stefan Büringer buringerst@vmware.com
…-ms-cache-unstructured

🌱 Cache unstructured in Cluster, MD and MS controller
Signed-off-by: Stefan Büringer buringerst@vmware.com
Signed-off-by: Stefan Büringer buringerst@vmware.com
🐛 tilt: set CR logger in tilt-prepare, fix allowed contexts
…unstructured

🌱 KCP: cache unstructured
…y_boostrap_configref

🐛 handle nil pointer in clusterctl describe
🌱 hack/observability: add tempo (for traces)
Signed-off-by: Stefan Büringer buringerst@vmware.com
🌱 util: cache list calls in cluster to objects mapper
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
…precated

🐛 Fix deprecation marker for RolloutAfter
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023

@damdo: This pull request references OCPCLOUD-2222 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link

Rebase looks fine, wondering though, should we squash down a bunch of the commits, we basically have setup, and then a bunch of tweaks to the setup, which I don't really need to care about the history of, WDYT?

@damdo
Copy link
Member Author

damdo commented Oct 9, 2023

/retest

3 similar comments
@damdo
Copy link
Member Author

damdo commented Oct 9, 2023

/retest

@damdo
Copy link
Member Author

damdo commented Oct 9, 2023

/retest

@damdo
Copy link
Member Author

damdo commented Oct 9, 2023

/retest

@damdo
Copy link
Member Author

damdo commented Oct 10, 2023

/hold
For manual testing

@damdo
Copy link
Member Author

damdo commented Oct 10, 2023

Waiting on the Hypershift fix openshift/hypershift#3087 to merge be contained in a CI image.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@JoelSpeed
Copy link

JoelSpeed commented Oct 12, 2023

/retitle OCPBUGS-17286,OCPCLOUD-2222: Merge https://github.com/kubernetes-sigs/cluster-api:v1.5.2 (3290c5a) into master

@openshift-ci openshift-ci bot changed the title OCPCLOUD-2222: Merge https://github.com/kubernetes-sigs/cluster-api:v1.5.2 (3290c5a) into master OCPBUGS-17286,OCPCLOUD-2222: Merge https://github.com/kubernetes-sigs/cluster-api:v1.5.2 (3290c5a) into master Oct 12, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 12, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 12, 2023

@damdo: This pull request references Jira Issue OCPBUGS-17286, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references OCPCLOUD-2222 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member Author

damdo commented Oct 13, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@damdo
Copy link
Member Author

damdo commented Oct 16, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@damdo
Copy link
Member Author

damdo commented Oct 16, 2023

/tide refresh

@openshift-ci openshift-ci bot merged commit 0f68bd5 into openshift:master Oct 16, 2023
8 checks passed
@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-17286: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-17286 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet