NO-JIRA: cmd/cluster/core/dump: Gather PodDisruptionBudgets too #3263
Conversation
Pod disruption budgets are important enough to be included in Insights tarballs [1], and they aren't all that big, so we should pick them up as a standard part of interesting namespaces too. This will help with things like auditing issues where we failed to drain (PDB too strict) or disrupted a core workload (PDB too weak or missing). Similar to openshift/oc@c32fac0143 (pkg/cli/admin/inspect/namespace: Gather PDBs too, 2021-03-03, openshift/oc#750). [1]: openshift/insights-operator#185
openshift-ci
bot
added
area/cli
wking
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@wking: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I'm going with |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/retest-required Now that openshift/cluster-config-operator#388 has landed, and possibly fixed the RHEL 8 vs. RHEL 9 dynamic linking issues. |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.16.0-202312061931.p0.g39a0c45.assembly.stream for distgit hypershift. |
What this PR does / why we need it:
Pod disruption budgets are important enough to be included in Insights tarballs, and they aren't all that big, so we should pick them up as a standard part of interesting namespaces too. This will help with things like auditing issues where we failed to drain (PDB too strict) or disrupted a core workload (PDB too weak or missing). Similar to openshift/oc@c32fac0143 (openshift/oc#750).
Checklist