Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "OCPBUGS-19106: Updating ose-cluster-config-operator-container image to be consistent with ART" #388

Conversation

wking
Copy link
Member

@wking wking commented Dec 6, 2023

Reverts #385

It's complicated, but while ART is building RHEL 9 HyperShift and cluster-config-operator images, both ART and CI are building mostly-RHEL-8 machine-config operator images. HyperShift invokes both some machine-config-* and the cluster-config-operator binaries. And the MCO binaries are currently RHEL 8 both in CI and in ART builds. Moving the CI cluster-config operator back to RHEL 8 might give us some breathing room vs. current 4.15 release-controller blocker failures like:

=== NAME  TestCreateClusterProxy/ValidateHostedCluster
   util.go:218:
       failed to ensure guest nodes became ready, ready: (0/2):
       Unexpected error:
           <wait.errInterrupted>:
           timed out waiting for the condition

Because of NodePool failures like:

 - lastTransitionTime: "2023-12-04T17:38:58Z"
    message: |-
      Failed to generate payload: error getting ignition payload: failed to execute cluster-config-operator: cluster-config-operator process failed: /payloads/get-payload431072810/bin/cluster-config-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by /payloads/get-payload431072810/bin/cluster-config-operator)
      /payloads/get-payload431072810/bin/cluster-config-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /payloads/get-payload431072810/bin/cluster-config-operator)
      : exit status 1
    observedGeneration: 1
    reason: InvalidConfig
    status: ""
    type: ValidGeneratedPayload

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 6, 2023
@openshift-ci-robot
Copy link

@wking: This pull request references Jira Issue OCPBUGS-19106, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #385

It's complicated, but while ART is building RHEL 9 HyperShift and cluster-config-operator images, both ART and CI are building mostly-RHEL-8 machine-config operator images. HyperShift invokes both some machine-config-* and the cluster-config-operator binaries. And the MCO binaries are currently RHEL 8 both in CI and in ART builds. Moving the CI cluster-config operator back to RHEL 8 might give us some breathing room vs. current 4.15 release-controller blocker failures like:

=== NAME  TestCreateClusterProxy/ValidateHostedCluster
  util.go:218:
      failed to ensure guest nodes became ready, ready: (0/2):
      Unexpected error:
          <wait.errInterrupted>:
          timed out waiting for the condition

Because of NodePool failures like:

- lastTransitionTime: "2023-12-04T17:38:58Z"
   message: |-
     Failed to generate payload: error getting ignition payload: failed to execute cluster-config-operator: cluster-config-operator process failed: /payloads/get-payload431072810/bin/cluster-config-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by /payloads/get-payload431072810/bin/cluster-config-operator)
     /payloads/get-payload431072810/bin/cluster-config-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /payloads/get-payload431072810/bin/cluster-config-operator)
     : exit status 1
   observedGeneration: 1
   reason: InvalidConfig
   status: ""
   type: ValidGeneratedPayload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Dec 6, 2023

/payload-job periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

@wking: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6c793360-93da-11ee-880c-32a0717f039d-0

@wking
Copy link
Member Author

wking commented Dec 6, 2023

The previous payload attempt hasn't launched a run as far as I can tell. Trying again:

/payload-job periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

@wking: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2785c6a0-93e0-11ee-8ddc-1689964b569c-0

@JoelSpeed
Copy link
Contributor

Still didn't seem to work, let's try again
/payload-job periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

@JoelSpeed: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a1e350f0-9414-11ee-89ff-2a13910a9c34-0

@JoelSpeed
Copy link
Contributor

/lgtm

Based on https://redhat-internal.slack.com/archives/C068LS7RS6S/p1701834669669239 I don't think we need to run the HyperShift tests, not sure why the payload job isn't triggering correctly

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-upgrade

Failures appear to be unrelated

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-upgrade

In response to this:

/override ci/prow/e2e-upgrade

Failures appear to be unrelated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Dec 6, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 6, 2023
@openshift-ci-robot
Copy link

@wking: This pull request references Jira Issue OCPBUGS-19106, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 6, 2023
@openshift-ci openshift-ci bot requested a review from gangwgr December 6, 2023 10:03
@openshift-merge-bot openshift-merge-bot bot merged commit c436b7a into openshift:master Dec 6, 2023
10 checks passed
@openshift-ci-robot
Copy link

@wking: Jira Issue OCPBUGS-19106: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19106 has been moved to the MODIFIED state.

In response to this:

Reverts #385

It's complicated, but while ART is building RHEL 9 HyperShift and cluster-config-operator images, both ART and CI are building mostly-RHEL-8 machine-config operator images. HyperShift invokes both some machine-config-* and the cluster-config-operator binaries. And the MCO binaries are currently RHEL 8 both in CI and in ART builds. Moving the CI cluster-config operator back to RHEL 8 might give us some breathing room vs. current 4.15 release-controller blocker failures like:

=== NAME  TestCreateClusterProxy/ValidateHostedCluster
  util.go:218:
      failed to ensure guest nodes became ready, ready: (0/2):
      Unexpected error:
          <wait.errInterrupted>:
          timed out waiting for the condition

Because of NodePool failures like:

- lastTransitionTime: "2023-12-04T17:38:58Z"
   message: |-
     Failed to generate payload: error getting ignition payload: failed to execute cluster-config-operator: cluster-config-operator process failed: /payloads/get-payload431072810/bin/cluster-config-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by /payloads/get-payload431072810/bin/cluster-config-operator)
     /payloads/get-payload431072810/bin/cluster-config-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /payloads/get-payload431072810/bin/cluster-config-operator)
     : exit status 1
   observedGeneration: 1
   reason: InvalidConfig
   status: ""
   type: ValidGeneratedPayload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the revert-385-art-consistency-openshift-4.15-ose-cluster-config-operator branch December 6, 2023 10:06
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-operator-container-v4.16.0-202312061430.p0.gc436b7a.assembly.stream for distgit ose-cluster-config-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants