OCPBUGS-25696: Apply Scheduling Configuration for kCCM #3382
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@orenc1: This pull request references Jira Issue OCPBUGS-25696, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
area/control-plane-operator
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@orenc1: This pull request references Jira Issue OCPBUGS-25696, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (yli2@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel, orenc1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold Revision a48a07f was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
https://issues.redhat.com/browse/OCPBUGS-25696 kCCM deployment was not respecting the node selector configured at hcp.spec.nodeSelector that was set with --node-selector flag in the create cli command. This PR fixes the issue, by applying 'SetDefaults()' to the deploymentConfig, which sets the node selector along with other required configurations (e.g. tolerations, affinity, replica count, etc.)
orenc1
force-pushed
the
missing_nodeselector_kccm
branch
from
a48a07f
to
eecee03
Compare
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@orenc1: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@orenc1: Jira Issue OCPBUGS-25696: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-25696 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.15 |
|
@orenc1: new pull request created: #3417 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.14 |
|
@orenc1: new pull request created: #3418 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-01-14-231715 |
What this PR does / why we need it:
kCCM deployment was not respecting the node selector configured at
hcp.spec.nodeSelectorthat was set with--node-selectorflag in the create cli command. This PR fixes the issue, by applyingSetDefaults()to thedeploymentConfig, which sets the node selector along with other required configurations (e.g. tolerations, affinity, replica count, etc.)Which issue(s) this PR fixes
Fixes # https://issues.redhat.com/browse/OCPBUGS-25696
Checklist