Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-27072: Apply Scheduling Configuration for kCCM #3418

Merged
merged 1 commit into from Feb 4, 2024
Merged

[release-4.14] OCPBUGS-27072: Apply Scheduling Configuration for kCCM #3418

merged 1 commit into from Feb 4, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3382

/assign orenc1

@imain
OCPBUGS-25696: Apply Scheduling Configuration for kCCM
e12027d 
https://issues.redhat.com/browse/OCPBUGS-25696
kCCM deployment was not respecting the node selector configured at hcp.spec.nodeSelector that was set with --node-selector flag in the create cli command.
This PR fixes the issue, by applying 'SetDefaults()' to the deploymentConfig, which sets the node selector along with other required configurations (e.g. tolerations, affinity, replica count, etc.)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 12, 2024
Merged
4 tasks
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-25696 has been cloned as Jira Issue OCPBUGS-27072. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-27072: Apply Scheduling Configuration for kCCM

In response to this:

This is an automated cherry-pick of #3382

/assign orenc1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-25696: Apply Scheduling Configuration for kCCM [release-4.14] OCPBUGS-27072: Apply Scheduling Configuration for kCCM Jan 12, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 12, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-27072, which is invalid:

  • expected dependent Jira Issue OCPBUGS-25696 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-25696 to target a version in 4.15.0, but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3382

/assign orenc1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Jan 12, 2024
davidvossel
davidvossel reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@LiangquanLi930
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-27072, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@orenc1: This pull request references Jira Issue OCPBUGS-27072, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@orenc1
Copy link
Contributor

orenc1 commented Feb 3, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 3, 2024
@openshift-ci-robot
Copy link

@orenc1: This pull request references Jira Issue OCPBUGS-27072, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-25696 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-25696 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 60e6124 and 2 for PR HEAD e12027d in total

@orenc1
Copy link
Contributor

orenc1 commented Feb 4, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 4, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7808fd6 into openshift:release-4.14 Feb 4, 2024
10 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-27072: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27072 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #3382

/assign orenc1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.14.0-202402041109.p0.g7808fd6.assembly.stream for distgit hypershift.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-02-06-000359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

@nirarg nirarg Awaiting requested review from nirarg

@LiangquanLi930 LiangquanLi930 Awaiting requested review from LiangquanLi930

Assignees

@davidvossel davidvossel

@orenc1 orenc1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @LiangquanLi930 @orenc1 @openshift-bot @openshift-merge-robot @davidvossel @imain