Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-26977: Required RBAC for network-node-identity is not created when hosted cluster networkType is set to Other. #3403

Merged
merged 1 commit into from Jan 25, 2024
Merged

OCPBUGS-26977: Required RBAC for network-node-identity is not created when hosted cluster networkType is set to Other. #3403

merged 1 commit into from Jan 25, 2024

Conversation

mvazquezc
Copy link
Member

What this PR does / why we need it:
Fixes #OCPBUGS-26977

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 11, 2024
@openshift-ci-robot
Copy link

@mvazquezc: This pull request references Jira Issue OCPBUGS-26977, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Fixes #OCPBUGS-26977

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 11, 2024
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Jan 11, 2024
@mvazquezc mvazquezc force-pushed the OCPBUGS-26977 branch 2 times, most recently from 99c5c57 to 2e2d745 Compare January 11, 2024 14:06
@jparrill
Copy link
Contributor

We've been working together into the PR review through a huddle. Already changes done.

/lgtm

@jparrill
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-26977, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jparrill
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 11, 2024
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-26977, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jparrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@csrwng
Copy link
Contributor

csrwng commented Jan 11, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, mvazquezc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7690059 and 2 for PR HEAD 2e2d745 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4191e17 and 1 for PR HEAD 2e2d745 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 257c0a5 and 0 for PR HEAD 2e2d745 in total

@openshift-ci-robot
Copy link

/hold

Revision 2e2d745 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2024
@bryan-cox
Copy link
Member

/retest

@bryan-cox
Copy link
Member

Removing previous hold since it was placed by failing tests
/Unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ef43500 and 2 for PR HEAD 2e2d745 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c32704f and 1 for PR HEAD 2e2d745 in total

@mvazquezc
OCPBUGS-26977: Required RBAC for network-node-identity is not created…
7f9d62a 
… when hosted cluster networkType is set to Other.

Signed-off-by: Mario Vazquez <mavazque@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 23, 2024

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 7f9d62a
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65afc826704d870008c3e8ce
😎 Deploy Preview https://deploy-preview-3403--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@csrwng
Copy link
Contributor

csrwng commented Jan 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9b08dcf and 2 for PR HEAD 7f9d62a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6c84753 and 1 for PR HEAD 7f9d62a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d7b8d75 and 0 for PR HEAD 7f9d62a in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@mvazquezc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8d96c1a into openshift:main Jan 25, 2024
12 checks passed
@openshift-ci-robot
Copy link

@mvazquezc: Jira Issue OCPBUGS-26977: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-26977 has not been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
Fixes #OCPBUGS-26977

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202401242108.p0.g8d96c1a.assembly.stream for distgit hypershift.
All builds following this will include this PR.

@csrwng
Copy link
Contributor

csrwng commented Jan 25, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 25, 2024
Merged
@openshift-cherrypick-robot
Copy link

@csrwng: new pull request created: #3467

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rtheis
Copy link
Contributor

rtheis commented Jan 26, 2024

/cherry-pick release-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 26, 2024
Closed
@openshift-cherrypick-robot
Copy link

@rtheis: new pull request created: #3474

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jonesbr17 pushed a commit to jonesbr17/hypershift that referenced this pull request Jan 30, 2024
@mvazquezc @jonesbr17
[release-4.15] OCPBUGS-28235: Required RBAC for network-node-identity…
8e9cc1f 
… is not created when hosted cluster networkType is set to Other.

This is a manual cherry-pick of openshift#3403

/assign csrwng
@jonesbr17 jonesbr17 mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@jparrill jparrill

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mvazquezc @openshift-ci-robot @jparrill @csrwng @bryan-cox @openshift-bot @openshift-cherrypick-robot @rtheis