New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-28538: Added docs to get other sdn providers deployed with agent provider #3405
Conversation
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mvazquezc: This pull request references Jira Issue OCPBUGS-26977, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
||
This document explains how to create a HostedCluster that runs an SDN provider different from OVNKubernetes. The document assumes that you already have the required infrastructure in place to create HostedClusters using the Agent provider. If not, please refer to the [Agent guide](./create-agent-cluster.md) and come back later. | ||
|
||
> **IMPORTANT**: The work described here is **not supported**. SDN providers **must** certify their software on HyperShift before it becomes a supported solution. The steps described here are just a technical reference for people that wants to try different SDN providers in HyperShift. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> **IMPORTANT**: The work described here is **not supported**. SDN providers **must** certify their software on HyperShift before it becomes a supported solution. The steps described here are just a technical reference for people that wants to try different SDN providers in HyperShift. | |
> **IMPORTANT**: The work described here is **not supported**. SDN providers **must** certify their software on HyperShift before it becomes a supported solution. The steps described here are just a technical reference for people who want to try different SDN providers in HyperShift. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to modify mkdocs.yml as well to include this in the directory.
Line 78 in 54242ed
- how-to/agent/create-agent-cluster.md |
462bb41
to
3e66951
Compare
Handing this PR over meanwhile @mvazquezc is OoO. |
/retitle OCPBUGS-26977,OCPBUGS-28538: Added docs to get other sdn providers deployed with agent provider |
@mvazquezc: This pull request references Jira Issue OCPBUGS-26977, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-28538, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3e66951
to
cf95a82
Compare
/retitle OCPBUGS-28538: Added docs to get other sdn providers deployed with agent provider |
cf95a82
to
9bb87bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of comments
|
||
2. Wait for the HostedCluster's API to be ready. Once it's ready, get the admin kubeconfig. | ||
|
||
3. Wait for compute nodes to join the cluster. Keep in mind since the SDN is not deployed yet, they will remain in `NotReady` state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to wait for nodes to join. You should be able to apply the manifests as long as you have a working API server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
||
2. Wait for the HostedCluster's API to be ready. Once it's ready, get the admin kubeconfig. | ||
|
||
3. Wait for compute nodes to join the cluster. Keep in mind since the SDN is not deployed yet, they will remain in `NotReady` state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, no need to wait for nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
/jira refresh |
@jparrill: This pull request references Jira Issue OCPBUGS-28538, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1fbaf69
to
5634e61
Compare
This PR includes Cilium and Calico SDNs to have them configured in the Hosted Cluster. In the Cilium part also covers some conformance tests that could be deployed into the HostedCluster to validate that the SDN is working as expected. Signed-off-by: Mario Vazquez <mavazque@redhat.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com> This commit includes the fixes for versions 4.14.10 and also from 4.15.z, making Cilium work as SDN properly. Also included configurations for IPv6 and Dual Stack. Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
5634e61
to
68d09f0
Compare
/jira refresh |
@jparrill: This pull request references Jira Issue OCPBUGS-28538, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (heli@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, mvazquezc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mvazquezc: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
@mvazquezc: Jira Issue OCPBUGS-28538: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-28538 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.16.0-202402140210.p0.ga58035c.assembly.stream.el9 for distgit hypershift. |
The backport is not needed because it's only documentation, but the affectation it's also covering 4.14 OCP versions. |
Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806 |
What this PR does / why we need it:
This PR adds docs to the agent provider section on how to get other SDN providers (Calico and Cilium) deployed in a HostedCluster.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:None
Checklist