Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Re-enable InPlace NodePool upgrade test for kubevirt (CNV-36608) #3600

Conversation

orenc1
Copy link
Contributor

@orenc1 orenc1 commented Feb 18, 2024

Reverts #3547

The fix for the inplace upgrade has been fixed on MCO side and merged at openshift/machine-config-operator#4190

Re-enabling the test to validate kubevirt provider can now perform NodePool InPlace upgrades.

@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Feb 18, 2024
@orenc1
Copy link
Contributor Author

orenc1 commented Feb 20, 2024

Verifying stability:
/test e2e-kubevirt-aws-ovn

@orenc1
Copy link
Contributor Author

orenc1 commented Feb 21, 2024

Verifying stability, 3rd time:
/test e2e-kubevirt-aws-ovn

@orenc1
Copy link
Contributor Author

orenc1 commented Feb 21, 2024

last run:

             --- FAIL: TestAutoscaling/PostTeardown/EnsureAPIBudget/hypershift-operator_read (0.00s) 

/test e2e-kubevirt-aws-ovn

@orenc1
Copy link
Contributor Author

orenc1 commented Feb 21, 2024

last run:

                 --- FAIL: TestCreateCluster/Main/break-glass-credentials/sre-break-glass/CSR_flow (0.14s) 

/test e2e-kubevirt-aws-ovn

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@orenc1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@orenc1 orenc1 changed the title Re-enable InPlace NodePool upgrade test for kubevirt (CNV-36608) NO-JIRA: Re-enable InPlace NodePool upgrade test for kubevirt (CNV-36608) Feb 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 22, 2024
@openshift-ci-robot
Copy link

@orenc1: This pull request explicitly references no jira issue.

In response to this:

Reverts #3547

The fix for the inplace upgrade has been fixed on MCO side and merged at openshift/machine-config-operator#4190

Re-enabling the test to validate kubevirt provider can now perform NodePool InPlace upgrades.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f4cf103 into openshift:main Feb 23, 2024
12 checks passed
@orenc1 orenc1 deleted the revert-3547-revert-3517-kubevirt_enable_inplace_upgrade branch February 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants