OCPBUGS-29652: nmstate, configure nmstate to keep service yamls #4190
Conversation
When [1] land to RHCOS the nmstate service will go back to previous behaviour, the /etc/nmstate/*.yml files are moved to .applied files, so we need to configure nmstate to keep the those files, if we don't do so MCO complains at in place upgrades since the file system has change. [1] nmstate/nmstate#2546 Signed-off-by: Enrique Llorente <ellorent@redhat.com>
qinqon
changed the title
|
/retest |
There was a problem hiding this comment.
Looks good. https://github.com/nmstate/nmstate/pull/2546/files#diff-ae6ab4ca7ea12f71746b70b459afebc7a9141af402bd09c239daa567c8f4bdd7R27 confirms that this is really syntax used by nmstate, so let's get it in
|
/lgtm |
|
/jira refresh |
|
@mkowalski: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle NO-JIRA: nmstate, configure nmstate to keep service yamls |
|
/jira refresh |
|
@mkowalski: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@qinqon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @Ksinny can you approve this ? |
|
/cc @sinnykumari can you approve this ? |
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski, qinqon, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@qinqon: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 4026f55
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-config-operator-container-v4.16.0-202402160210.p0.g4026f55.assembly.stream.el8 for distgit ose-machine-config-operator. |
|
/cherry-pick release-4.15 |
|
@qinqon: new pull request created: #4192 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
qinqon
changed the title
|
@qinqon: Jira Issue OCPBUGS-29652 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@qinqon: Jira Issue OCPBUGS-29652 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@qinqon: Jira Issue OCPBUGS-29652: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29652 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
When nmstate/nmstate#2546 land to RHCOS the nmstate service will go back to previous behaviour, the /etc/nmstate/*.yml files are moved to .applied files, so we need to configure nmstate to keep the those files, if we don't do so MCO complains at in place upgrades since the file system has change.
The original in place problem is described at nmstate/nmstate#2499:
And the original issue was:
https://issues.redhat.com/browse/RHEL-19680