Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1773: Featuregate autoprovision #4411

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

HOSTEDCP-1773: Featuregate autoprovision #4411

wants to merge 3 commits into from

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Jul 24, 2024 •
edited
Loading

What this PR does / why we need it:

  • This PR introduces support for Feature gates using Autoprovisioning as the driving use case.
  • Featuregates are enabled via "k8s.io/component-base/featuregate" and using Cluster API featuregates implementation as the main example.
  • Autoprovisioning is implemented via karpenter aws native provider. When Autoprovisioning feature gate is enabled:
    • We create a shim NodePool to generate the userdata.
    • We deploy Karpenter aws provider management side watching the guest cluster.
    • We install the Karpenter CRDs in the guest cluster.
    • We automatically approve all CSRs.
    • We watch Karpeneter ec2Classes and inject the right userdata and ami.

In future the implementation and consumer facing APIs of Autoprovision might / might not differ completely. We might /might not choose to integrate karpenter with Cluster API or even use different.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@enxebre
Copy link
Member Author

enxebre commented Jul 24, 2024

/hold
to add unit tests

@openshift-ci openshift-ci bot added do-not-merge/needs-area do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 24, 2024
@openshift-ci openshift-ci bot requested review from csrwng and hasueki July 24, 2024 11:18
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Jul 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Jul 24, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 24, 2024

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit ab088e6
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/66a0e2d0ee9ebe0008a4bee2
😎 Deploy Preview https://deploy-preview-4411--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@enxebre
Copy link
Member Author

enxebre commented Jul 24, 2024

/test netlify/hypershift-docs/deploy-preview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

@enxebre: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-kubevirt-aws-ovn-reduced
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aks
  • /test e2e-aws-metrics
  • /test e2e-azure
  • /test e2e-azure-ovn-conformance
  • /test e2e-conformance
  • /test e2e-ibmcloud-iks
  • /test e2e-ibmcloud-roks
  • /test e2e-kubevirt-aws-ovn
  • /test e2e-kubevirt-azure-ovn
  • /test e2e-kubevirt-metal-conformance
  • /test e2e-openstack
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aks
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-azure
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/test netlify/hypershift-docs/deploy-preview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

@enxebre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks bc85aef link false /test e2e-aks
ci/prow/e2e-aws bc85aef link true /test e2e-aws
ci/prow/images bc85aef link true /test images
ci/prow/e2e-azure bc85aef link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@enxebre enxebre changed the title Featuregate autoprovision HOSTEDCP-1773: Featuregate autoprovision Jul 24, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2024 •
edited by openshift-ci bot
Loading

@enxebre: This pull request references HOSTEDCP-1773 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

  • This PR introduces support for Feature gates using Autoprovisioning as the driving use case.
  • Featuregates are enabled via "k8s.io/component-base/featuregate" and using Cluster API featuregates implementation as the main example.
  • Autoprovisioning is implemented via karpenter aws native provider. When Autoprovisioning feature gate is enabled:
  • We create a shim NodePool to generate the userdata.
  • We deploy Karpenter aws provider management side watching the guest cluster.
  • We install the Karpenter CRDs in the guest cluster.
  • We automatically approve all CSRs.
  • We watch Karpeneter ec2Classes and inject the right userdata and ami.

In future the implementation and consumer facing APIs of Autoprovision might / might not differ completely. We might /might not choose to integrate karpenter with Cluster API or even use different.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@enxebre
Copy link
Member Author

enxebre commented Jul 26, 2024

/retest

@enxebre
Copy link
Member Author

enxebre commented Jul 26, 2024

/retest cancel

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 26, 2024

@enxebre: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-kubevirt-aws-ovn-reduced
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aks
  • /test e2e-aws-metrics
  • /test e2e-azure
  • /test e2e-azure-ovn-conformance
  • /test e2e-conformance
  • /test e2e-ibmcloud-iks
  • /test e2e-ibmcloud-roks
  • /test e2e-kubevirt-aws-ovn
  • /test e2e-kubevirt-azure-ovn
  • /test e2e-kubevirt-metal-conformance
  • /test e2e-openstack
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aks
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-azure
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/retest cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoelSpeed
Copy link
Contributor

/hold

After some discussion today, we would like to discuss the impact of this change and the long term plan here before we merge. We have some concerns about introducing provider specific implementations, how this will be supported and the implications of having a feature-gated feature where we know the future implementation likely won't behave in the same manor.

Would like to have a conversation with @enxebre @elmiko @sub-mod @newtonheath @celebdor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@hasueki hasueki Awaiting requested review from hasueki

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@enxebre @openshift-ci-robot @openshift-merge-robot @JoelSpeed