OCPBUGS-38967: [release-4.17] Remove go workspaces

[csrwng]

What this PR does / why we need it:
Removes the go.work and go.work.sum files from the repository. Updates the Makefile to not use go workspaces.
Updates the vendored staticcheck so it won't fail on new style range statements.
Makes minor fixes flagged by staticcheck
Adds instructions for setting up a Go workspace in HACKING doc

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-38755

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[csrwng]

/jira cherry-pick OCPBUGS-38755

[openshift-ci-robot]

@csrwng: Detected clone of Jira Issue OCPBUGS-38755 with correct target version. Will retitle the PR to link to the clone.
/retitle OCPBUGS-38967: [release-4.17] Remove go workspaces

In response to this:

/jira cherry-pick OCPBUGS-38755

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@csrwng: This pull request references Jira Issue OCPBUGS-38967, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Removes the go.work and go.work.sum files from the repository. Updates the Makefile to not use go workspaces.
Updates the vendored staticcheck so it won't fail on new style range statements.
Makes minor fixes flagged by staticcheck
Adds instructions for setting up a Go workspace in HACKING doc

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[csrwng]

/jira refresh

[openshift-ci-robot]

@csrwng: This pull request references Jira Issue OCPBUGS-38967, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-38755 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-38755 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

/lgtm

[csrwng]

Backport of PR #4582

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1827c48 and 2 for PR HEAD 67baa6f in total

[csrwng]

/retest-required

[openshift-ci]

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@csrwng: Jira Issue OCPBUGS-38967: All pull requests linked via external trackers have merged:

• openshift/hypershift#4620

Jira Issue OCPBUGS-38967 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
Removes the go.work and go.work.sum files from the repository. Updates the Makefile to not use go workspaces.
Updates the vendored staticcheck so it won't fail on new style range statements.
Makes minor fixes flagged by staticcheck
Adds instructions for setting up a Go workspace in HACKING doc

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-38755

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.