-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openshift apiserver: Make the global pullsecret accessible #606
Conversation
The openshift-apiserver doesn't access the global pullsecret from the api but reads it from /var/lib/kubelet/config.json. Without this change, imagestream imports that rely on the global pull secret don't work. This fixes the "[sig-builds][Feature:Builds] imagechangetriggers imagechangetriggers should trigger builds of all types" conformance test. Ref https://issues.redhat.com/browse/HOSTEDCP-257
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nice! |
/cherrypick release-4.8 |
@alvaroaleman: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@alvaroaleman: #606 failed to apply on top of branch "release-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The openshift-apiserver doesn't access the global pullsecret from the
api but reads it from /var/lib/kubelet/config.json. Without this change,
imagestream imports that rely on the global pull secret don't work.
This fixes the "[sig-builds][Feature:Builds] imagechangetriggers
imagechangetriggers should trigger builds of all types" conformance
test.
Ref https://issues.redhat.com/browse/HOSTEDCP-257