Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically infer infra cr GVK #927

Merged
merged 1 commit into from Jan 28, 2022

Conversation

alvaroaleman
Copy link
Contributor

@alvaroaleman alvaroaleman commented Jan 27, 2022

What this PR does / why we need it:
We currently require the type meta on the infra CR to be set correctly
which isn't done by default. Infer it instead to simplify implementing
new providers and remove one possible source of errors.

/assign @enxebre

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

We currently require the type meta on the infra CR to be set correctly
which isn't done by default. Infer it instead to simplify implementing
new providers and remove one possible source of errors.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@enxebre
Copy link
Member

enxebre commented Jan 28, 2022

For ref:
We can't simply infraCR.GetObjectKind().GroupVersionKind() as it comes empty because the client strips the metadata kubernetes/client-go#541.

GVKForObject works because it looks at the schema https://github.com/kubernetes-sigs/controller-runtime/blob/v0.11.0/pkg/client/apiutil/apimachinery.go#L76.

Thanks @alvaroaleman!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@alvaroaleman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 20f42df into openshift:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants