-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1766110: Checking if image name is valid, prune otherwise #198
Bug 1766110: Checking if image name is valid, prune otherwise #198
Conversation
In some cases we have some images on the blob storage that contain names considered to be invalid by the ImageStream API. Names containing / or even % are not considered valid for Images. As some customers are not able to prune their images due to this error this patch adds a check and sets the image to be pruned if it contains an invalid name(they should not be there anyways).
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1749256, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
@openshift-bot: This pull request references Bugzilla bug 1749256, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/retitle Bug 1766110: Checking if image name is valid, prune otherwise |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1766110, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
/assign @dmage @adambkaplan |
/retitle [release-3.11] Bug 1766110: Checking if image name is valid, prune otherwise |
/retitle [release-4.1] Bug 1766110: Checking if image name is valid, prune otherwise |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@eparis ready to go. |
/retitle Bug 1766110: Checking if image name is valid, prune otherwise |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1766110 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #194
/assign ricardomaraschini