Kubernetes 1.17.0 #209
Kubernetes 1.17.0 #209
Conversation
openshift-ci-robot
added
size/XXL
dmage
force-pushed
the
kubernetes-1.17.0-rc.2
branch
2 times, most recently
from
fd68b62
to
8a8d85e
Compare
|
/retest |
dmage
force-pushed
the
kubernetes-1.17.0-rc.2
branch
from
8a8d85e
to
f13064c
Compare
|
/assign @adambkaplan |
| k8s.io/apiserver v0.0.0-20191016112112-5190913f932d // indirect | ||
| k8s.io/client-go v0.0.0-20191016111102-bec269661e48 | ||
| k8s.io/client-go v0.17.0 |
dmage
force-pushed
the
kubernetes-1.17.0-rc.2
branch
from
f13064c
to
211b049
Compare
|
/retest |
| Namespace: namespace, | ||
| Name: "request_duration_seconds", | ||
| Help: "Request latency in seconds for each operation.", | ||
| Objectives: map[float64]float64{0.5: 0.05, 0.9: 0.01, 0.99: 0.001}, |
There was a problem hiding this comment.
@dmage For my own education - are there docs on what this map does?
There was a problem hiding this comment.
Found them:
// Objectives defines the quantile rank estimates with their respective
// absolute error. If Objectives[q] = e, then the value reported for q
// will be the φ-quantile value for some φ between q-e and q+e. The
// default value is an empty map, resulting in a summary without
// quantiles.
So with this configuration we have the 50% +/- 5%, 90% +/- 1%, and 99% +/- 0.1%
There was a problem hiding this comment.
@dmage Was the 50/90/99 reporting previous behavior, or is this new?
There was a problem hiding this comment.
@adambkaplan it's the old default
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.