Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COPY --from doesn't fail when source file doesn't exist #137

Closed
rcerven opened this issue Aug 20, 2019 · 2 comments
Closed

COPY --from doesn't fail when source file doesn't exist #137

rcerven opened this issue Aug 20, 2019 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@rcerven
Copy link

rcerven commented Aug 20, 2019

when copying file from previous stage
via COPY --from=previous_stage
build doesn't fail on COPY command when source file doesn't exist

--> COPY --from=stage1 /opt/non-existent /file_from_stage1
--> RUN cat /file_from_stage1
cat: /file_from_stage1: No such file or directory
running 'cat /file_from_stage1' failed with exit code 1
trozet added a commit to trozet/ovn-kubernetes-1 that referenced this issue Jan 8, 2020
@trozet
Fixes missing oc client during openshift image build
d3b67cb 
Trailing slash was missing for destination for the COPY. There is an
issue with OpenShift image buildiner, silently ignoring a failed COPY:

openshift/imagebuilder#137

Patch ensures that oc actually exists after the COPY operation.

Signed-off-by: Tim Rozet <trozet@redhat.com>
@nalind nalind mentioned this issue Feb 20, 2020
Merged
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2020
@nalind
Copy link
Member

nalind commented Sep 16, 2020

This should be fixed by #148, but I didn't phrase it right for that to happen automatically when it was merged. Closing.

@nalind nalind closed this as completed Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nalind @openshift-bot @rcerven @openshift-ci-robot