dockerclient: detect ENOENT when copying #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect cases where, when filtering the output of archiveFromFile() or archiveFromContainer() to net only sources which match a source path, we fail to match anything. When that happens, return an os.ErrNotExist error from the archive's Close() method. The archiveFromContainer() function now returns a ReadCloser where it previously returned only a Reader. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
openshift-ci-robot
added
size/L
|
Note for reviewers: the dockerclient package isn't used in buildah; we have containers/buildah#2111 to check for this there. |
|
/test unit |
1 similar comment
|
/test unit |
|
This should fix #137. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect cases where, when filtering the output of
archiveFromFile()orarchiveFromContainer()to net only sources which match a source path, we fail to match anything. When that happens, return anos.ErrNotExisterror from the archive'sClose()method. ThearchiveFromContainer()function now returns aReadCloserwhere it previously returned only aReader.This aims to fix https://bugzilla.redhat.com/show_bug.cgi?id=1794768.