-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerclient: detect ENOENT when copying #148
Conversation
Detect cases where, when filtering the output of archiveFromFile() or archiveFromContainer() to net only sources which match a source path, we fail to match anything. When that happens, return an os.ErrNotExist error from the archive's Close() method. The archiveFromContainer() function now returns a ReadCloser where it previously returned only a Reader. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Note for reviewers: the dockerclient package isn't used in buildah; we have containers/buildah#2111 to check for this there. |
/test unit |
1 similar comment
/test unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming happy tests
This should fix #137. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Detect cases where, when filtering the output of
archiveFromFile()
orarchiveFromContainer()
to net only sources which match a source path, we fail to match anything. When that happens, return anos.ErrNotExist
error from the archive'sClose()
method. ThearchiveFromContainer()
function now returns aReadCloser
where it previously returned only aReader
.This aims to fix https://bugzilla.redhat.com/show_bug.cgi?id=1794768.