NewBuilder(): always initialize Args #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We modify the Args map member of a Builder object, but we don't make a copy of the initial value that we're given in NewBuilder() before doing that, so we end up modifying the map that we're given. This can be surprising. In the dispatcher for ARG instructions, we weren't checking that the map wasn't nil before attempting to assign values to it, so we could panic. Fix this by making a fresh map in NewBuilder() and initializing it using the zero or more values from the passed-in map. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
openshift-ci-robot
added
size/XS
|
LGTM, but I'm kinda surprised that we were ever passing in a nil value to |
The CLI versions of podman and buildah weren't, but the openshift builder is. openshift/builder#130 will probably change that. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modify the
Argsmap member of a Builder object, but we don't make a copy of the initial value that we're given inNewBuilder()before doing that, so we end up modifying the map that we're given. This can be surprising.In the dispatcher for ARG instructions, we weren't checking that the map wasn't
nilbefore attempting to assign values to it, so we could panic, as in openshift/builder#129.Fix this by making a fresh map in
NewBuilder()and initializing it using the zero or more values from the passed-in map.