New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openshift-3.11] dockerclient: detect ENOENT when copying #162
[openshift-3.11] dockerclient: detect ENOENT when copying #162
Conversation
LGTM assuming happy tests |
LGTM |
7b55daf
to
fcbf651
Compare
We modify the Args map member of a Builder object, but we don't make a copy of the initial value that we're given in NewBuilder() before doing that, so we end up modifying the map that we're given. This can be surprising. In the dispatcher for ARG instructions, we weren't checking that the map wasn't nil before attempting to assign values to it, so we could panic. Fix this by making a fresh map in NewBuilder() and initializing it using the zero or more values from the passed-in map. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Detect cases where, when filtering the output of archiveFromFile() or archiveFromContainer() to net only sources which match a source path, we fail to match anything. When that happens, return an os.ErrNotExist error from the archive's Close() method. The archiveFromContainer() function now returns a ReadCloser where it previously returned only a Reader. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
The dockerclient/archive.go had error output with `%w` when it should have been `%v`. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
When a source specified as a glob can't be found, return an error that can be identified by as an os.ErrIsNotExist, wrapped or otherwise, even if we have to drop the glob from the error string to ensure that for versions of Go that don't wrap errors. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
fcbf651
to
ededc3f
Compare
/override continuous-integration/travis-ci/pr |
/refresh |
/lgtm |
1 similar comment
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/refresh |
This patch rolls up changes from #147, #148, #152, and #153. The latter three aim to be consumable in OpenShift 3.11 to fix https://bugzilla.redhat.com/show_bug.cgi?id=1794768.