Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerclient/testdata/copychown/Dockerfile: remove an irrelevant instruction #189

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

nalind
Copy link
Member

@nalind nalind commented Mar 24, 2021

Running "ls" on the /usr/bin/script provided by util-linux doesn't contribute anything to this test, so don't bother with that.

…ruction

Running "ls" on the /usr/bin/script provided by util-linux doesn't
contribute anything to this test, so don't bother with that.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind
Copy link
Member Author

nalind commented Mar 24, 2021

h/t to @TomSweeneyRedHat for asking about it in #188.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@rhatdan
Copy link
Contributor

rhatdan commented Mar 24, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 21860de into openshift:master Mar 24, 2021
@nalind nalind deleted the irrelevant branch April 9, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants