Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARG: allows to process multiple ARGS in single step #210

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

flouthoc
Copy link
Contributor

Allows imagebuilder to process multiple args in a single step since
docker supports that.

Usage

FROM alpine
ARG foo=0 bar=1
RUN echo $foo, $bar

Closes: containers/buildah#3737

@flouthoc flouthoc changed the title ARG: allow process multiple ARGS in single step ARG: allows to process multiple ARGS in single step Jan 24, 2022
Allows imagebuilder to process multiple args in a single step since
docker supports that.

Usage

```dockerfile
FROM alpine
ARG foo=0 bar=1
RUN echo $foo, $bar
```

Signed-off-by: Aditya R <arajan@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@flouthoc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nalind
Copy link
Member

nalind commented Jan 24, 2022

/approve
/lgtm

@nalind nalind self-assigned this Jan 24, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit f4c8496 into openshift:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile issue: ARG requires exactly one argument definition
3 participants