builder: create WORKDIR with USER ownership

[giuseppe]

let the executor deal with creating the WorkingDirectory.

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

[giuseppe]

I've tried the reproducer here #87 and could not reproduce the issue.

Needed for: containers/buildah#3840

[rhatdan]

LGTM, but we need @nalind opinion on this.

[nalind]

Is there an explanation of why this change is being made? Conformance tests don't get run in CI; do they continue to pass with this change?

[giuseppe]

Is there an explanation of why this change is being made? Conformance tests don't get run in CI; do they continue to pass with this change?

if we postpone the mkdir to containers/buildah#3840 then we can create it with the correct ownership.

Do I need Docker to run the conformance tests? I've pointed it to Podman (running locally with sudo podman system service -t 0 unix:///var/run/docker.sock) and I get all sort of failures.

I've vendored this change into containers/buildah#3840 to run the conformance tests there

[giuseppe]

Do I need Docker to run the conformance tests? I've pointed it to Podman (running locally with sudo podman system service -t 0 unix:///var/run/docker.sock) and I get all sort of failures.

stupid question. We clearly need Docker, going to test with that.

[giuseppe]

/hold

[nalind]

if we postpone the mkdir to containers/buildah#3840 then we can create it with the correct ownership.

Please make sure that's noted in the commit log.

[rhatdan]

@giuseppe could you force push this to trigger CI.

[rhatdan]

/approve

[flouthoc]

LGTM @nalind PTAL

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@giuseppe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[TomSweeneyRedHat]

LGTM

[giuseppe]

fixed, Buildah tests are also green: containers/buildah#3840

[nalind]

Did we run the conformance tests?

[giuseppe]

I've used this branch in containers/buildah#3840

[nalind]

I was referring to this repository's conformance tests, which CI doesn't run.

[nalind]

Something like nalind@b2bca3b.