TestDispatchFromFlagsAndUseBuiltInArgs: expect variants to be used #272
Conversation
If we're on a platform where the local platform spec includes a non-empty variant value, expect it to be used in tests that create a Builder for the local platform. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
openshift-ci
bot
added
the
approved
|
LGTM |
|
@siretart PTAL |
|
@flouthoc PTAL |
|
@flouthoc: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind, siretart The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@nalind: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
If we're on a platform where the local platform spec includes a non-empty variant value, expect it to be used in tests that create a Builder for the local platform.
Should fix #263.